cdc_queue.cpp change to uint32_t length, print(0ULL) bugfix #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDC_TRANSMIT_QUEUE_BUFFER_PACKET_NUMBER > 512 or CDC_RECEIVE_QUEUE_BUFFER_PACKET_NUMBER > 512. print(0ULL) bugfix.
catbraincell
changed the title
Member
|
Hi @warmonkey thanks for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Summary
raise cdc buffer size 32KB limit due to uint16_t length variables.
This PR fixes bug:
cdc queue limited
now CDC_TRANSMIT_QUEUE_BUFFER_PACKET_NUMBER and/or CDC_RECEIVE_QUEUE_BUFFER_PACKET_NUMBER both can be greater than 512. which every buffer size is 64B, 64*512=32768
print(0ULL) no output
Serial.print(0ULL) gives empty output arduino/ArduinoCore-API#178